repl: use pushScope to pass results from --eval -E #860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve my slopy `input` prototype from f7704b4. ``` hnix --repl --eval -E '{ a = 42; }' hnix> a 42 ``` In a case when argument passed to `-E` is not an attribute set, we can't push it to scope directly, so we wrap it in attribute set under `input` attribute, like previous version. ``` hnix --repl --eval -E '42' hnix> input 42 ``` Related to haskell-nix#292 haskell-nix#172.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve my slopy
inputprototype from f7704b4.In a case when argument passed to
-Eis not an attribute set,we can't push it to scope directly, so we wrap it
in attribute set under
inputattribute, like previous version.Related to #292 #172.
This calls for further refactoring and removal of some superfluous code. Tab completion needs to look in current scope as well => Draft.