Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[servant-docs] Export renderCurlBasePath lens #1706

Merged
merged 2 commits into from
Mar 5, 2025
Merged

[servant-docs] Export renderCurlBasePath lens #1706

merged 2 commits into from
Mar 5, 2025

Conversation

xsebek
Copy link
Contributor

@xsebek xsebek commented Sep 16, 2023

Add missing renderCurlBasePath lens re-export.

A workaround is to use:

import Servant.Docs.Internal qualified as SD (renderCurlBasePath)

@xsebek xsebek mentioned this pull request Sep 16, 2023
Merged
tchoutri
tchoutri requested changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@tchoutri tchoutri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Could you please add a changelog entry in changelog.d/? :)

@xsebek xsebek force-pushed the xsebek/add-curl-doc-lens branch from eb9b413 to d4c0b58 Compare March 5, 2025 18:56
@xsebek
Copy link
Contributor Author

xsebek commented Mar 5, 2025

@tchoutri I added a changelog entry and rebased the PR.

@tchoutri tchoutri moved this to In progress in Servant 0.20.3.0 Mar 5, 2025
@tchoutri tchoutri merged commit 591ed85 into haskell-servant:master Mar 5, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in Servant 0.20.3.0 Mar 5, 2025
@tchoutri
Copy link
Contributor

tchoutri commented Mar 5, 2025

Thanks a lot @xsebek!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tchoutri tchoutri tchoutri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Servant 0.20.3.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xsebek @tchoutri