Generalise toStream and toBStream
#7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`streaming-bytestring-0.3.0` removes support for GHC 7 anyway, so no point us claiming compatibility with `base >= 4.6`
This also breaks the direct dependency on `transformers`.
JackKelly-Bellroy
force-pushed
the
generalise-tostream-tobstream
branch
from
d062bb7 to
b4fb8e3
Compare
|
Is there anything I can do to help move this along? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit of a general cleanup PR: remove all the deprecated aliases that have built up (and fix simplified subsumption-related errors when building with GHC 9.0) and then generalise
toStreamandtoBStreamso they return the final value from their input conduit.Because it too bumps
hspec:Fixes #4