Skip to content

WIP: Add a function to compute symbols from library modules #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion haskell-names.cabal
Original file line number Diff line number Diff line change
@@ -246,6 +246,9 @@ Library
, bytestring >= 0.10.4.0 && < 0.11
, data-lens-light >= 0.1.2.1 && < 0.2
, traverse-with-class >= 1.0.0.0 && < 1.1
, template-haskell >= 2.9 && < 2.14
, hint >= 0.7 && < 0.9
, th-lift, th-lift-instances, th-orphans
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to avoid adding more dependencies to library target. Could you try to implement this feature as a separate executable? Though this really can be useful. This feature is quite big though... It might be convenient to use it directly from library. But it looks more like an idea for different project rather that patch for haskell-names.

if impl(ghc <= 7.8)
Build-depends: tagged >= 0.8.4 && < 0.9
Hs-source-dirs: src
@@ -262,6 +265,7 @@ Library
Language.Haskell.Names.ModuleSymbols
Language.Haskell.Names.SyntaxUtils
Language.Haskell.Names.GetBound
Language.Haskell.Names.Reify

Other-modules:
Language.Haskell.Names.Open.Base
@@ -287,7 +291,7 @@ Test-suite test
, mtl >= 2.2.1 && < 2.3
, filepath >= 1.1 && <1.5
, containers >= 0.2 && < 0.6
, tasty >= 0.12 && < 0.13
, tasty >= 0.12 && < 1.1
, tasty-golden >= 2.2.1 && < 2.4
, filemanip >= 0.3.6.3 && < 0.4
, pretty-show >= 1.6.1 && < 1.7
228 changes: 228 additions & 0 deletions src/Language/Haskell/Names/Reify.hs
Original file line number Diff line number Diff line change
@@ -0,0 +1,228 @@
-- | Load the symbols of a module for which we do not have source.
-- This module could be added to the @haskell-names@ package.

{-# LANGUAGE CPP, FlexibleInstances, ScopedTypeVariables, TemplateHaskell, TypeFamilies #-}
{-# OPTIONS -Wall -fno-warn-orphans #-}

module Language.Haskell.Names.Reify
( findModuleSymbols
, dangerous
) where

import Control.Monad (msum, when)
import Control.Monad.State as State (lift, modify, runStateT, StateT)
import Data.List (isPrefixOf)
import Data.Set as Set (insert, member, Set)
import Instances.TH.Lift ()
import qualified Language.Haskell.Exts.Syntax as Exts (ModuleName(ModuleName), Name(Symbol, Ident))
import Language.Haskell.Interpreter as Hint (runInterpreter, getModuleExports, ModuleElem(..))
import Language.Haskell.Names as Names -- (Symbol(..))
import Language.Haskell.Names.SyntaxUtils ()
import Language.Haskell.TH (ExpQ, reify, Type(TupleT))
import Language.Haskell.TH.Lift as TH (deriveLiftMany, lift)
import Language.Haskell.TH.Syntax as TH
(Dec(..), Info(..), lookupValueName, lookupTypeName, ModName(..),
Name(..), NameFlavour(..), NameSpace(..), OccName(..), PkgName(..), Q, runIO, TypeFamilyHead(..))
import System.IO (hPutStrLn, stderr)

$(deriveLiftMany [''Hint.ModuleElem, ''Exts.ModuleName, ''Names.Symbol, ''Exts.Name])

-- | Given a module name, get its top level 'Symbol' list. This is done
-- using the geModuleExports function from the @hint@ package, then
-- using @template-haskell@'s 'lookupValueName' and 'reify' functions to
-- learn everything about those symbols, and then converting that info
-- to the @haskell-names@ 'Symbol' type. The results should compare to
-- the output of 'loadBase'.
findModuleSymbols :: Int -> (Name -> Maybe Info) -> String -> ExpQ -- Q [Symbol]
findModuleSymbols verbosity special defmod = do
modelems <- either (error . show) id <$> runIO (runInterpreter (getModuleExports defmod))
symbols <- concat <$> mapM (moduleElemSymbols verbosity special defmod) modelems :: Q [Symbol]
TH.lift symbols

moduleElemSymbols :: Int -> (Name -> Maybe Info) -> String -> Hint.ModuleElem -> Q [Symbol]
moduleElemSymbols verbosity special defmod e = do
(infos, syms) <- runStateT (do names <- (moduleElemNames defmod) e
mapM (nameInfo verbosity special defmod) names) mempty
return $ concatMap (infoToSymbols defmod syms) infos

-- | We have a ModuleElem, which represents some symbols imported from
-- defmod. These symbols may not actually be located in defmod,
-- defmod might have re-exported them.
moduleElemNames :: String -> Hint.ModuleElem -> StateT (Set String) Q [Either String Name]
moduleElemNames defmod (Hint.Fun i) =
(: []) <$> lookupNameWith defmod lookupValueName i
moduleElemNames defmod (Hint.Class c ms) = do
cname <- lookupNameWith defmod lookupTypeName c
mnames <- mapM (\m -> lookupNameWith defmod lookupValueName m) ms
return (cname : mnames)
moduleElemNames defmod (Hint.Data t fs) = do
tname <- lookupNameWith defmod lookupTypeName t
fnames <- mapM (lookupNameWith defmod lookupValueName) fs
return (tname : fnames)

nameInfo :: Int -> (Name -> Maybe Info) -> String -> Either String Name -> StateT (Set String) Q Info
nameInfo verbosity special defmod name =
either (\s -> error $ "nameInfo - could not reify " ++ s ++ " in " ++ defmod ++ " - is it imported?")
(State.lift . reify' verbosity special)
name

lookupNameWith :: String -> (String -> Q (Maybe TH.Name)) -> String -> StateT (Set String) Q (Either String TH.Name)
lookupNameWith defmod look i = do
mname1 <- State.lift $ look (defmod ++ "." ++ i)
mname2 <- State.lift $ look i
case msum [mname1, mname2] of
Nothing -> case stripSymbol i of
Nothing -> return (Left i)
Just i' -> modify (Set.insert i') >> lookupNameWith defmod look i'
Just name -> return (Right name)

stripSymbol :: String -> Maybe String
stripSymbol s | length s >= 3 && head s == '(' && last s == ')' = Just (take (length s - 2) (drop 1 s))
stripSymbol _ = Nothing

infoToSymbols :: String -> Set String -> Info -> [Names.Symbol]
infoToSymbols defmod syms (VarI name _type _mdecs) =
[Names.Value
{symbolModule = thNameToModName defmod name,
symbolName = thNameToExtsName syms name}]
infoToSymbols defmod syms (ClassI (ClassD _ cname _ _ _) _) =
[Names.Class
{symbolModule = thNameToModName defmod cname,
symbolName = thNameToExtsName syms cname}]
infoToSymbols defmod syms (ClassOpI mname _typ cname) =
[Names.Method
{symbolModule = thNameToModName defmod mname,
symbolName = thNameToExtsName syms mname,
className = thNameToExtsName syms cname}]
infoToSymbols defmod syms (TyConI (DataD _ tname _ _ _ _)) =
[Names.Data
{symbolModule = thNameToModName defmod tname,
symbolName = thNameToExtsName syms tname}]
infoToSymbols defmod syms (TyConI (NewtypeD _ tname _ _ _ _)) =
[Names.NewType
{symbolModule = thNameToModName defmod tname,
symbolName = thNameToExtsName syms tname}]
infoToSymbols defmod syms (DataConI cname _type tname) =
[Names.Constructor
{symbolModule = thNameToModName defmod cname,
symbolName = thNameToExtsName syms cname,
typeName = thNameToExtsName syms tname}]
infoToSymbols defmod syms (TyConI (TySynD tname _ _typ)) =
[Names.Type
{symbolModule = thNameToModName defmod tname,
symbolName = thNameToExtsName syms tname}]
infoToSymbols defmod syms (FamilyI (OpenTypeFamilyD (TypeFamilyHead tname _ _ _)) insts) =
[Names.TypeFam
{symbolModule = thNameToModName defmod tname,
symbolName = thNameToExtsName syms tname,
associate = findAssociateName insts}]
infoToSymbols defmod syms (FamilyI (ClosedTypeFamilyD (TypeFamilyHead tname _ _ _) _) insts) =
[Names.TypeFam
{symbolModule = thNameToModName defmod tname,
symbolName = thNameToExtsName syms tname,
associate = findAssociateName insts}]
infoToSymbols defmod syms (FamilyI (DataFamilyD tname _ _) insts) =
[Names.DataFam
{symbolModule = thNameToModName defmod tname,
symbolName = thNameToExtsName syms tname,
associate = findAssociateName insts}]
-- I'm sure these will show up shortly :-(
infoToSymbols _ _ i@(FamilyI _ _) = error $ "unimplemented - infoToSymbols " ++ show i
infoToSymbols _ _ i@(ClassI _ _) = error $ "unimplemented - infoToSymbols " ++ show i
infoToSymbols _ _ i@(TyConI _) = error $ "unimplemented - infoToSymbols " ++ show i
infoToSymbols _ _ i@(PrimTyConI _ _ _) = error $ "unimplemented - infoToSymbols " ++ show i
infoToSymbols _ _ i@(TyVarI _ _) = error $ "unimplemented - infoToSymbols " ++ show i

findAssociateName :: [Dec] -> Maybe (Exts.Name ())
findAssociateName _ = Nothing

thNameToExtsName :: Set String -> TH.Name -> Exts.Name ()
thNameToExtsName _ (TH.Name (OccName o) TH.NameS) = error ("NameS o=" ++ show o)
thNameToExtsName _ (TH.Name (OccName o) (TH.NameQ (ModName modname))) = error ("NameQ o=" ++ show o ++ ", modname=" ++ show modname)
thNameToExtsName _ (TH.Name (OccName o) (TH.NameU _n)) = error ("NameU o=" ++ show o)
thNameToExtsName _ (TH.Name (OccName o) (TH.NameL _n)) = error ("NameL o=" ++ show o)
thNameToExtsName syms (TH.Name (OccName o) (TH.NameG VarName (PkgName _) (ModName _))) = symbolOrIdent syms o
thNameToExtsName syms (TH.Name (OccName o) (TH.NameG DataName (PkgName _) (ModName _))) = symbolOrIdent syms o
thNameToExtsName syms (TH.Name (OccName o) (TH.NameG TcClsName (PkgName _) (ModName _))) = symbolOrIdent syms o

thNameToModName :: String -> TH.Name -> Exts.ModuleName ()
thNameToModName d (TH.Name _ TH.NameS) = Exts.ModuleName () d
thNameToModName _ (TH.Name _ (TH.NameQ (ModName modname))) = Exts.ModuleName () modname
thNameToModName d (TH.Name _ (TH.NameU _)) = Exts.ModuleName () d
thNameToModName d (TH.Name _ (TH.NameL _)) = Exts.ModuleName () d
thNameToModName _ (TH.Name _ (TH.NameG VarName (PkgName _) (ModName modname))) = Exts.ModuleName () modname
thNameToModName _ (TH.Name _ (TH.NameG DataName (PkgName _) (ModName modname))) = Exts.ModuleName () modname
thNameToModName _ (TH.Name _ (TH.NameG TcClsName (PkgName _) (ModName modname))) = Exts.ModuleName () modname

symbolOrIdent :: Set String -> String -> Exts.Name ()
symbolOrIdent syms s | Set.member s syms = Exts.Symbol () s
symbolOrIdent _ s = Exts.Ident () s

-- | Reify non-dangerous symbols. Specifically, symbols whose definitions
-- use implicit parameters.
reify' :: Int -> (Name -> Maybe Info) -> Name -> Q Info
reify' verbosity danger name =
maybe (do when (verbosity > 0) (runIO (hPutStrLn stderr ("reify " ++ show name)))
reify name)
return
(danger name)

-- | Special case for functions in the prelude that template haskell
-- can't handle. This is a useful example, but the user can supply
-- their own. It would be great to fix GHC so this wasn't needed.
dangerous :: Name -> Maybe Info
dangerous name =
msum [ nameMatch ($(lookupValueName "error" >>= \(Just x) -> TH.lift x) :: Name) name
, nameMatch (Name (OccName "undefined") (NameG VarName (PkgName "base") (ModName "GHC.Err"))) name
, nameMatch ("Control.Lens.Fold", "^?!") name
, nameMatch ("Control.Lens.Fold", "^@?!") name
, nameMatch ("Control.Lens.Fold", "foldl1Of") name
, nameMatch ("Control.Lens.Fold", "foldl1Of'") name
, nameMatch ("Control.Lens.Fold", "foldr1Of") name
, nameMatch ("Control.Lens.Fold", "foldr1Of'") name
, nameMatch ("Control.Lens.Traversal", "singular") name
, nameMatch ("Control.Lens.Traversal", "unsafeSingular") name
, nameMatch ("GHC.IO.Exception", "assertError") name
, nameMatch ("Test.HUnit.Base", "Assertable") name
, nameMatch ("Test.HUnit.Base", "assert") name
, nameMatch ("Test.HUnit.Base", "assertBool") name
, nameMatch ("Test.HUnit.Base", "assertString") name
, nameMatch ("Test.HUnit.Lang", "assertEqual") name
, nameMatch ("Test.HUnit.Lang", "assertFailure") name
, nameMatch ("Test.HUnit.Base", "ListAssertable") name
, nameMatch ("Test.HUnit.Base", "listAssert") name
, nameMatch ("Test.HUnit.Base", "Testable") name
, nameMatch ("Test.HUnit.Base", "test") name
, nameMatch ("Test.HUnit.Base", "@=?") name
, nameMatch ("Test.HUnit.Base", "@?=") name
, nameMatch ("Test.HUnit.Base", "@?") name
, nameMatch ("Test.HUnit.Base", "~=?") name
, nameMatch ("Test.HUnit.Base", "~?") name
, nameMatch ("Test.HUnit.Base", "~?=") name
, nameMatch ("Test.HUnit.Base", "~:") name]

-- | Class of ways we can select a (dangerous to reify) 'Name' and
-- return the corresponding 'Info'.
class NamePattern a where
nameMatch :: a -> Name -> Maybe Info

instance NamePattern Name where
nameMatch name1 name2 | name1 == name2 = Just (VarI name2 (TupleT 0) Nothing)
nameMatch _ _ = Nothing

instance NamePattern (String, String) where
nameMatch (mname1, sname1) name@(Name (OccName sname2) (NameG _ _ (ModName mname2)))
| mname1 == mname2 && sname1 == sname2 = Just (VarI name (TupleT 0) Nothing)
nameMatch _ _ = Nothing

instance NamePattern (String, String, String) where
nameMatch (pname1, mname1, sname1) name@(Name (OccName sname2) (NameG _ (PkgName pname2) (ModName mname2)))
| mname1 == mname2 && sname1 == sname2 && isPrefixOf (pname1 ++ "-") pname2 =
Just (VarI name (TupleT 0) Nothing)
nameMatch _ _ = Nothing

-- avoid this one
instance NamePattern String where
nameMatch sname1 name@(Name (OccName sname2) (NameG _ _ _))
| sname1 == sname2 = Just (VarI name (TupleT 0) Nothing)
nameMatch _ _ = Nothing
2 changes: 1 addition & 1 deletion tests/environment/Prelude.symbols.golden

Large diffs are not rendered by default.

8 changes: 5 additions & 3 deletions tests/run.hs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{-# LANGUAGE FlexibleInstances, ImplicitParams, MultiParamTypeClasses,
FlexibleContexts, GADTs, TypeApplications #-}
FlexibleContexts, GADTs, TypeApplications, TemplateHaskell #-}
import Test.Tasty hiding (defaultMain)
import Test.Tasty.Golden
import Test.Tasty.Golden.Manage
@@ -29,6 +29,7 @@ import Language.Haskell.Names.Imports
import Language.Haskell.Names.Annotated
import Language.Haskell.Names.Open
import Language.Haskell.Names.ModuleSymbols
import Language.Haskell.Names.Reify
import Language.Haskell.Names.SyntaxUtils
import qualified Language.Haskell.Names.GlobalSymbolTable as Global

@@ -93,8 +94,9 @@ annotationTest environment (path, modul) = goldenTest path run where
environmentTests :: TestTree
environmentTests = goldenTest path run where
run = do
baseEnvironment <- loadBase
writeSymbols out (baseEnvironment Map.! (U.ModuleName () "Prelude"))
let preludeSymbols :: [Symbol]
preludeSymbols = sort $(findModuleSymbols 0 dangerous "Prelude")
writeSymbols out preludeSymbols
path = "tests/environment/Prelude.symbols"
out = path <.> "out"