Align stack buffer on 32 bytes #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include stdint.h for uint32_t portability
|
Nice! |
newhoggy
reviewed
Sep 30, 2019
| // align stack buffer on 32 bytes | ||
| uint8_t unaligned_buffer[W8_BUFFER_SIZE + 32]; | ||
| uint8_t * buffer = unaligned_buffer + ((uintptr_t)unaligned_buffer & (uintptr_t)0x10); | ||
| fprintf(stderr, "Buffer is at address %p of size %zu\n", buffer, (size_t) W8_BUFFER_SIZE); |
There was a problem hiding this comment.
Perhaps it's better to declare a stack allocated array for alignment and get the compiler to handle it:
uint64_t aligned_buffer[W8_BUFFER_SIZE / 8];
uint8_t * buffer = (uint8_t *)aligned_buffer;
Unless we need alignment at 32 bytes, in which case we'll have to use your solution.
newhoggy
reviewed
Sep 30, 2019
| uint32_t phi_buffer[W8_BUFFER_SIZE]; | ||
|
|
||
| uint32_t unaligned_phi_buffer[W8_BUFFER_SIZE + 32]; | ||
| uint32_t * phi_buffer = (uint32_t*) ((void*)unaligned_phi_buffer + ((uintptr_t)unaligned_phi_buffer & (uintptr_t)0x10)); |
There was a problem hiding this comment.
This is possibly overkill since + 32 for uint32_t is actually an extra 32 * 4 = 128 bytes.
|
I'll merge anyway given that the fix works for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include stdint.h for uint32_t portability
Relates to issue #53