Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concat arguments when enabling haddock #10783

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jasagredo
Copy link
Collaborator

@jasagredo jasagredo commented Feb 8, 2025

Arguments were unioned with <> which is left-biased, therefore -haddock swallowed all other args as indeed described in #10782.

QA

The example in #10782 now correctly will fail even if documentation is enabled.


Template Α: This PR modifies behaviour or interface

Include the following checklist in your PR:

@jasagredo jasagredo force-pushed the js/haddock-swallows-other branch from 734f4f9 to 8e1f76b Compare February 8, 2025 15:48
@jasagredo
Copy link
Collaborator Author

I think the bug was introduced by 80f0a65, which makes the expression modified in this PR to be non-empty if documentation was enabled. I however don't know if I'm introducing some subtle bug by not ignoring the default args anymore but concatenating them with the user supplied args.

@jasagredo jasagredo force-pushed the js/haddock-swallows-other branch from ad84f9e to 3a43753 Compare February 9, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enabling documentation seems to swallow ghc-options passed
1 participant