Skip to content

Monitor also ghc.shim file on Windows #10853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Monitor also ghc.shim file on Windows #10853

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions cabal-install/src/Distribution/Client/ProjectPlanning.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -989,6 +989,9 @@ programsMonitorFiles progdb =
monitorFileSearchPath
(programMonitorFiles prog)
(programPath prog)
++ if programId prog == "ghc" && buildOS == Windows
then [monitorFile $ programPath prog -<.> "shim"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if the file doesn't exist?

else []
]

-- | Select the bits of a 'ProgramDb' to monitor for value changes.
Expand Down
13 changes: 13 additions & 0 deletions changelog.d/pr-10853
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
synopsis: Monitor `ghc.shim` on Windows
packages: cabal-install
prs: #10853
issues: #10850

description: {

- On Linux it is the `ghc` executable that changes when changing compiler
version in GHCup (the symlink points to a new location) but on Windows it is
the companion `ghc.shim` file that changes. This file is now also monitored
for changes to trigger rebuilds.

}
Loading