Skip to content

feat(Cabal): cpp-options apply only to .hs files#11997

Open
zlonast wants to merge 2 commits into
haskell:masterfrom
zlonast:zlonast/fix-crypton
Open

feat(Cabal): cpp-options apply only to .hs files#11997
zlonast wants to merge 2 commits into
haskell:masterfrom
zlonast:zlonast/fix-crypton

Conversation

@zlonast

@zlonast zlonast commented Jun 21, 2026

Copy link
Copy Markdown
Collaborator

cpp-options apply only to .hs files; GHC ignores -optP for non-Haskell
files (and since 9.10 this behavior is explicit/enforced)


Template Α: This PR modifies behaviour or interface

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog.
  • Tests have been added. (Ask for help if you don’t know how to write them! Ask for an exemption if tests are too complex for too little coverage!)

-> SymbolicPathX 'AllowAbsolute Pkg (Dir Artifacts)
-> SymbolicPathX 'AllowAbsolute Pkg File
-> SymbolicPath Pkg (Dir Artifacts)
-> SymbolicPath Pkg File

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's typo from rebase

@zlonast zlonast linked an issue Jun 21, 2026 that may be closed by this pull request
@zlonast zlonast added re: preprocessors Concerning preprocessors such as alex and happy re: ghc-options Concerning passing options to GHC re: ghc 9.8 labels Jun 21, 2026
@zlonast zlonast force-pushed the zlonast/fix-crypton branch from 1fae1db to cbb2305 Compare June 22, 2026 11:38
@zlonast zlonast changed the title Fix crypton cpp-options apply only to .hs files Jun 22, 2026
@zlonast zlonast marked this pull request as ready for review June 22, 2026 11:40
@zlonast zlonast changed the title cpp-options apply only to .hs files featCabal): cpp-options apply only to .hs files Jun 22, 2026
@zlonast zlonast changed the title featCabal): cpp-options apply only to .hs files feat(Cabal): cpp-options apply only to .hs files Jun 22, 2026
@philderbeast

Copy link
Copy Markdown
Collaborator

I tested cabal-install:exe:cabal from this pull request on crypton and it builds without the error of #11992.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

attention: needs-review re: ghc 9.10 re: ghc-options Concerning passing options to GHC re: preprocessors Concerning preprocessors such as alex and happy

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failure to find included cbits blake2/blake2.h

2 participants