Included targets in cabal's bash-completion. #1932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When commpleting for cabal build/repl/test/bench, this completes the possible targets depending on their types. This is a temporary workaround, the definitive solution would be to include those targets in cabal itself, via ``--list-options''.
|
Does this do completion for exes or the lib too? From the code it looks like it only does testsuites or benchmarks. Also is it case insensitive? We can have "benchmark" or "Benchmark" (or even "beNCHmark") in .cabal files. |
Now handling executables: - completing run target - completing executables on build target Improvements: - removed false positives on completion
|
@dcoutts, I've added a new commit:
About the completion for libraries, I'm unsure about how it should work: cabal build will already build the libraries without need of completion, cabal repl will load them. But maybe there is a use case that I'm missing. |
|
OK, I think this can be merged. @rudymatela Thanks for your contribution! |
23Skidoo
added a commit
that referenced
this pull request
Jul 15, 2014
Included targets in cabal's bash-completion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When commpleting for cabal build/repl/test/bench, this completes the possible
targets depending on their types. This is a temporary workaround, the
definitive solution would be to include those targets in cabal itself, via
``--list-options''.
In other words, when typing "cabal repl [tab]", only option arguments (starting with --) are offered for completion. This commit solves that by adding possible targets to the list.
As mentioned before, this is a temporary workaround, code searches in current directory for a ".cabal" file and "parses" it to know which targets to complete.
This partially solves issue #1382