Bootstrap generation fix for exe-only dependencies #8042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mikolaj
approved these changes
Mar 11, 2022
robx
force-pushed
the
fix-bootstrap-selfref
branch
from
982c825 to
c17b976
Compare
Kleidukos
approved these changes
Mar 12, 2022
Kleidukos
added
merge me
This isn't currently a concrete problem, but surfaced when adding a dependency to cabal-install:exe.
jneira
force-pushed
the
fix-bootstrap-selfref
branch
from
c17b976 to
4416ea5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Not entirely sure what to do with this patch. It's a fix for a bug in bootstrap generation that was triggered by adding a dependency to the cabal-install executable in #7921, but that dependency is no longer there.)
Before this change, with 'signal' as a dependency for
cabal-install:exe:cabal, the dependency list ended
The first copy of "cabal-install" is the library target, which
is a dependency of the final executable target. But when
the bootstrap build encounters "cabal-install", it tries
building the executable target right away, which fails due
to the missing "signal" dependency.