-
Notifications
You must be signed in to change notification settings - Fork 710
Add wasm32-wasi to recognized arch/os #8096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for the PR. Please kindly compare with the very recent #8065 and ask in either of the PRs if you need any help. |
@Mikolaj Thanks for reminding; would you take another look now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. CI is borked independently (cache?).
I also suspect a stale cache issue here; would you accept a patch that bumps cache name from |
@fgaz: is this similar to what you proposed on #hackage? |
I proposed to add a workflow to fill (=> flush) the cache so we don't have to increase that number every time, but it doesn't seem to be working yet (#8097). Maybe pr and branch caches are separate? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it right to add the architecture to cabal before adding it to ghc? Shouldn't it be the opposite?
#8097 didn't work, @TerrorJack could you open a pr with the workaround you mentioned? |
I would use a date ( (about why I think we will need invalidate it regularly here: #7952 (comment)) |
I've added a commit in place to see whether the workaround works; if you think it is better to open a separate PR and merge that first, I'll also be fine to do that.
I'll open GHC MR to add the arch/os pair soon. But still, I'd like the Cabal PR to be opened and reviewed earlier, since it blocks other pending PRs of ghc boot libs, due to |
CI is now green 👀 |
This patch adds
wasm32
to known archs, andwasi
to known oss. It's a part of the work of adding webassembly support to ghc at https://gitlab.haskell.org/ghc/ghc/-/merge_requests/7632.