Skip to content

Remove enableProcessJobs entirely #8312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jneira
Copy link
Member

@jneira jneira commented Jul 22, 2022

To fix windows process killing using ctrl+c. It was being used for for windows > 7 and process > 1.6.9 but cabal does not honour ctrl+c for such setup (tested manually)

Fixes #8208, better alternative than #8295

To fix windows process killing using ctrl+c
Copy link
Collaborator

@robx robx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good from my side (though it'd be good to get a review from someone involved in adding enableProcessJobs).

@jneira jneira marked this pull request as draft July 22, 2022 20:22
@jneira
Copy link
Member Author

jneira commented Jul 25, 2022

We cant remove enableProcessJobs unconditionally cause windows need it to call posix executables, see #8208 (comment)

@jneira jneira closed this Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interrupting cabal-3.8.0.0.20220526 and master with ctrl+c makes it hang on windows
2 participants