-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make lukko
flag default to off.
#322
base: master
Are you sure you want to change the base?
Conversation
3c6a5d3
to
c7c0c2f
Compare
I was thinking we could start by flipping the flag in cabal, as the main user of hackage-security. However, this PR is a sensible second step. Or am I missing something? |
Note that so far we have a commented-out line turning off lukko in the project file: hackage-security/cabal.project Line 15 in d160ca4
This PR should also touch this line. Probably it makes sense to just delete it. |
I think I just misunderstood the ask from the dev meeting on Thursday. I can make the PR to set the lukko flag to off in cabal and get that done first before this. |
You can flip it in
One possibility is to keep |
Thanks, Bodigrim! Co-authored-by: ˌbodʲɪˈɡrʲim <[email protected]>
Based on discussions from haskell/cabal#10724, which was spurred by the comment here: haskellari/lukko#39 (comment)