Optimize instance Ord of SourcePos #172
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to issue #171.
This is partial remedy, aiding somewhat with "creative" users who pass the entire input into the
parse
function — both as the input, and as its SourceName / filename. This makesSourceName
arbitrarily large — hence, comparing first by the strict-Int fields makes a lot of sense, and does help somewhat (not terribly well) according to measurements.@parsonsmatt I've credited you in
Co-Authored-By
— for you've made the observation about the stock-derived Ord instance in the issue thread. Feel free to raise objection if you'd not like that, I'll promptly remove.