Removed create method in the unit test class and refactored code.

hassanhabib · Jun 13, 2024 · 8e399f7 · 8e399f7
1 parent b9c2df9
commit 8e399f7
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 12 deletions.
diff --git a/....Unit/Services/Foundations/ChatCompletions/ChatCompletionServiceTests.Validations.Send.cs b/....Unit/Services/Foundations/ChatCompletions/ChatCompletionServiceTests.Validations.Send.cs
@@ -59,7 +59,8 @@ private async Task ShouldThrowValidationExceptionOnSendIfRequestIsNullAsync()
             invalidChatCompletion.Request = null;
 
             var invalidChatCompletionException =
-                createInvalidChatCompletionException();
+                new InvalidChatCompletionException(
+                    message: "Chat completion is invalid."); ;
 
             invalidChatCompletionException.AddData(
                 key: nameof(ChatCompletion.Request),
@@ -107,7 +108,8 @@ private async Task ShouldThrowValidationExceptionOnSendIfRequestIsInvalidAsync(s
             };
 
             var invalidChatCompletionException =
-                createInvalidChatCompletionException();
+                new InvalidChatCompletionException(
+                    message: "Chat completion is invalid.");
 
             invalidChatCompletionException.AddData(
                 key: nameof(ChatCompletion.Request.Model),

diff --git a/...d.AI.OpenAI.Tests.Unit/Services/Foundations/ChatCompletions/ChatCompletionServiceTests.cs b/...d.AI.OpenAI.Tests.Unit/Services/Foundations/ChatCompletions/ChatCompletionServiceTests.cs
@@ -156,11 +156,5 @@ private static Filler<ChatCompletion> ChatCompletionFiller()
 
             return filler;
         }
-
-        private static InvalidChatCompletionException createInvalidChatCompletionException()
-        {
-            return new InvalidChatCompletionException(
-                message: "Chat completion is invalid.");
-        }
     }
 }
diff --git a/Standard.AI.OpenAI/Services/Foundations/ChatCompletions/ChatCompletionService.Exceptions.cs b/Standard.AI.OpenAI/Services/Foundations/ChatCompletions/ChatCompletionService.Exceptions.cs
@@ -118,7 +118,6 @@ private async ValueTask<ChatCompletion> TryCatch(
         private static ChatCompletionValidationException CreateChatCompletionValidationException(
             Xeption innerException)
         {
-
             return new ChatCompletionValidationException(
                 message: "Chat completion validation error occurred, fix errors and try again.",
                 innerException);
@@ -127,7 +126,6 @@ private static ChatCompletionValidationException CreateChatCompletionValidationE
         private static ChatCompletionDependencyException CreateChatCompletionDependencyException(
             Xeption innerException)
         {
-
             return new ChatCompletionDependencyException(
                 message: "Chat completion dependency error occurred, contact support.",
                 innerException);
@@ -136,7 +134,6 @@ private static ChatCompletionDependencyException CreateChatCompletionDependencyE
         private static ChatCompletionDependencyValidationException CreateChatCompletionDependencyValidationException(
             Xeption innerException)
         {
-
             return new ChatCompletionDependencyValidationException(
                 "Chat completion dependency validation error occurred, fix errors and try again.",
                 innerException);
@@ -145,7 +142,6 @@ private static ChatCompletionDependencyValidationException CreateChatCompletionD
         private static ChatCompletionServiceException CreateChatCompletionServiceException(
             Xeption innerException)
         {
-
             return new ChatCompletionServiceException(
                 message: "Chat completion service error occurred, contact support.",
                 innerException);