ddn run jwt-gen #111
Open
ddn run jwt-gen #111
+118
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ommand line. Docs are in the readme of the jwt scripts folder.
|
todo: test on windows |
|
Supergraph build was successful! 🎉 Build URLs:
Console URLs:
Commit ID: b350ce2 |
|
Supergraph build was successful! 🎉 Build URLs:
Console URLs:
Commit ID: ae5bc02 |
typhonius
reviewed
Feb 14, 2025
| @@ -79,3 +79,6 @@ definition: | |||
| docker-stop: | |||
| bash: for file in compose*.yaml $(find ../.data -type f -name "compose.yaml"); do docker compose -f $file down -v; done | |||
| powershell: docker compose -f compose.yaml down -v; docker compose -f .data/compose.yaml down -v | |||
| jwt-gen: | |||
| bash: cd ../scripts/jwt && npm i && node ./jwt.mjs --env $(find ../../ -name '.env.cloud.*' -print -quit) -r customer -u 7 | |||
There was a problem hiding this comment.
Couple of nitpicks:
- Do we need to do an
npm ifor every command invocation? Users could run that themselves as part of the initial set up - The jwt script is context aware so we don't need to cd into the directory to invoke
There was a problem hiding this comment.
I can go either way. I like having it for the cases where I forgot to do it, and it adds milliseconds to the script if it already exists. Can go with your preference.
There was a problem hiding this comment.
Can I be a pain and ask that we remove the npm i so the ddn run just calls the script. The script has uses -r customer -u 7 by default so we could always omit those too for simplicity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a new ddn run script that invokes the jwt gen tool from the command line. Docs are in the readme of the jwt scripts folder.