Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add queries examples #90

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

motleydev
Copy link
Contributor

No description provided.

Copy link
Collaborator

@typhonius typhonius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of changes noted in the comments. I believe @sandalsoft is going to create a PR with an updated .gitignore that we should piggy-back on.

Would love if the queries directory had a brief README too

.env Outdated Show resolved Hide resolved
.env.local Outdated Show resolved Hide resolved
collibra_import.csv Outdated Show resolved Hide resolved
engine/build/auth_config.json Outdated Show resolved Hide resolved
engine/build/metadata.json Outdated Show resolved Hide resolved
engine/build/open_dd.json Outdated Show resolved Hide resolved
meta.sh Outdated Show resolved Hide resolved
@motleydev
Copy link
Contributor Author

Well, apologies about all the changed files! That was careless on my part. I didn't realize I had some extra cruft in there. I'll take a look at removing the extra files.

@motleydev
Copy link
Contributor Author

@typhonius What's the goal of an additional readme? It's documented in the wiki, but I'd almost rather have some kind of script invoke these queries with ddn run --file.gql or something and then it makes sense to document. Thoughts?

@@ -0,0 +1,43 @@
query CustomerDashboard {
billing(where: { customerId: { _eq: "7" } }) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why we're hard coding this as 7 when CustomerBehaviorAnalysis above uses a variable? I'm easy with either but consistency across both would be best.

@typhonius
Copy link
Collaborator

@typhonius What's the goal of an additional readme? It's documented in the wiki, but I'd almost rather have some kind of script invoke these queries with ddn run --file.gql or something and then it makes sense to document. Thoughts?

Mostly to act as a quick reference for each of the files to show what each does and what the intention is when demonstrating (especially for public view vs our private wiki).

I love the idea of a command too—maybe a simple shell script in the queries directory to invoke it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants