Finserv

[sandalsoft]

Added the first data sources for the Financial Services data model.

[typhonius]

@sandalsoft the reason CI failed is because it's coming from a forked repo and doesn't (currently) have access to secrets. I'm in two minds:

• We branch PRs off hasura/axiom as origin rather than forks
• We implement something like https://github.com/orgs/community/discussions/50161#discussioncomment-5824158 (which I already started over in [WIP] Allow forked repos to have actions re-rerun by repo owners #70)

[typhonius]

Adding some comments here - the rest of the files/metadata etc look great. I'll run a test with a custom .env.cloud.finserv before merging though

[typhonius]

None of the engine/build directories should be on the top level, it's nested in hasura/ and should be gitignored (if it's not already)

[typhonius]

Same as above

[typhonius]

Same as above

[typhonius]

We need this .env file to stay in the repo to allow DDN to be spun up for users easily (commands reference it within the .hasura/context.yaml. I'm open to the idea of us creating an env.template and having a setup step be to copy it across though.

[typhonius]

Same as above - this is referenced in .hasura/context.yaml. That said, it might be time to think about restructuring how the .env and .env.local work, whether we need both, and whether it's better to create template files instead. Maybe a future PR?

[typhonius]

We probably want to leave the default project as test which should (now) reference axiom-test env.

[typhonius]

And I've switched this one over to axiom-dev now too

[typhonius]

Do we need this if the dir has files in?

[typhonius]

We might need to ignore hasura/.env and hasura/.env.local (for now). I put some comments on the deleted files as they're referenced in hasura/.hasura/context.yaml

[typhonius]

I've gotten rid of these in #96 so the only one to ignore would be .env.telco.template (and any finserv template file that you add in)

[typhonius]

Sorry, one other thing, can we please also add .DS_Store to this as well please?

[github-actions]

Supergraph build was successful! 🎉

Build URLs:

• https://axiom-dev-7a0b40a151.ddn.hasura.app/graphql
• https://axiom-dev-f657544258.ddn.hasura.app/graphql

Console URLs:

• https://console.hasura.io/project/axiom-dev/build/7a0b40a151
• https://console.hasura.io/project/axiom-dev/build/f657544258

Commit ID: 4fd4a0f

[typhonius]

@sandalsoft the reason CI failed is because it's coming from a forked repo and doesn't (currently) have access to secrets. I'm in two minds:

• We branch PRs off hasura/axiom as origin rather than forks
• We implement something like https://github.com/orgs/community/discussions/50161#discussioncomment-5824158 (which I already started over in [WIP] Allow forked repos to have actions re-rerun by repo owners #70)

Ok I fixed this in #70 by setting up a CI environment and using pull_request_target as a workflow trigger so you should be able to continue to use the repo fork rather than a branch here