Small-Tweaks

[seanparkross]

Description 📝

• Update Deployment/Self-Hosted section label capitalization: /deployment/self-hosted/
• Pre-emptive client side partial fix for cors error on data.pro.hasura.io

Quick Links 🚀

Assertion Tests 🤖

[hasura-bot]

DX: Assertion Testing

✅ Diff

The PR's diff indicates adjustments to the headers' capitalization and new CORS headers, which improve conventionality and compatibility with cross-origin requests. The explicit error handling and user feedback in the fetchUser function are beneficial additions for better debugging and fault tolerance. The label change from 'Self-hosted' to 'Self-Hosted' in category.json is a minor but good consistency fix, as it adheres to the capitalization convention often used in titles.

❌ Integrated

While the diff's changes make sense individually, there are concerns about how they collectively impact the existing codebase. The introduction of 'mode: cors', 'credentials: include', and broad CORS headers may have security implications requiring further review. Furthermore, the commented out fetchUser call in DocRootLayout/index.js hints at in-progress work, leaving doubt about the readiness of the PR for integration with the other files. Proper verification on the stage environment, as mentioned in the TODO comment, should be conducted before finalizing the PR. Lastly, it's important to ensure that these CORS changes align with the intended access control policy for the application.

[hasura-bot]

@seanparkross Thanks for your PR! I've assigned @robertjdominguez to review it.

[cloudflare-workers-and-pages]

Deploying ddn-docs with    Cloudflare Pages

Latest commit:	f912abf
Status:	✅  Deploy successful!
Preview URL:	https://aa83f7b0.v3-docs-eny.pages.dev
Branch Preview URL:	https://small-tweaks-20250203.v3-docs-eny.pages.dev

View logs