-
Notifications
You must be signed in to change notification settings - Fork 29
docs: improve JWT configuration page #873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@hgiasac Thanks for your PR! I've assigned @seanparkross to review it. |
DX: Assertion Testing✅ DiffThe PR introduces a detailed, structured configuration example using YAML, which is in line with modern practices and tends to be easier for users to understand than JSON. Replacing 'stringified_json' with 'StringifiedJson' improves consistency in naming conventions. The splitting of ✅ IntegratedThe PR’s updated YAML configuration is consistent with the rest of the documentation and maintains the same level of detail and clarity seen in other sections. It introduces additional security measures by providing a defaults example for new required fields like |
"allowed_skew": "optional-number-of-seconds-in-integer", | ||
"header": "optional-key-to-indicate-cookie-or-authorization-header" | ||
} | ||
```yaml title="globals/metadata/auth-config.hml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hgiasac So this section has changed to be about the AuthConfig definition rather than the JWT token definition. Do we not need a JWT payload definition also?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. That JWT definition is a JSON string in v2 when configuring the HASURA_GRAPHQL_JWT_SECRET
env variable. In Hasura DDN, JWT is just an auth mode of AuthConfig
and the syntax is different from v2.
We can link the definition to the JWT section in AuthConfig reference instead.
Description 📝
Many JWT configurations in Hasura v2 are no longer valid in Hasura DDN. This PR rewrites the JWT configuration page to improve the correctness.
Quick Links 🚀
https://fix-jwt-auth-configuration.v3-docs-eny.pages.dev/auth/jwt/jwt-configuration/
Assertion Tests 🤖