Update to TS SDK v5, support biginteger representation (#35)

hasura · May 31, 2024 · ebad66f · ebad66f
1 parent 702a95e
commit ebad66f
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 9 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -8,6 +8,8 @@ This changelog documents the changes between release versions.
 Changes to be included in the next upcoming release
 
 - Added a default .gitignore that ignores node_modules in the connector template ([#34](https://github.com/hasura/ndc-nodejs-lambda/pull/34))
+- Updated to NDC TypeScript SDK to v5.0.0 ([#35](https://github.com/hasura/ndc-nodejs-lambda/pull/35))
+  - The BigInt scalar type now uses the biginteger type representation
 
 ## [1.4.0] - 2024-05-08
 - Removed type inference recursion limit ([#33](https://github.com/hasura/ndc-nodejs-lambda/pull/33)). This enables the use of very nested object graphs.

diff --git a/ndc-lambda-sdk/package-lock.json b/ndc-lambda-sdk/package-lock.json
diff --git a/ndc-lambda-sdk/package.json b/ndc-lambda-sdk/package.json
@@ -30,7 +30,7 @@
     "url": "git+https://github.com/hasura/ndc-nodejs-lambda.git"
   },
   "dependencies": {
-    "@hasura/ndc-sdk-typescript": "^4.6.0",
+    "@hasura/ndc-sdk-typescript": "^5.0.0",
     "@tsconfig/node20": "^20.1.3",
     "commander": "^11.1.0",
     "cross-spawn": "^7.0.3",

diff --git a/ndc-lambda-sdk/src/connector.ts b/ndc-lambda-sdk/src/connector.ts
@@ -67,10 +67,11 @@ export function createConnector(options: ConnectorOptions): sdk.Connector<Config
 
     getCapabilities: function (configuration: Configuration): sdk.CapabilitiesResponse {
       return {
-        version: "0.1.2",
+        version: "0.1.3",
         capabilities: {
           query: {
-            variables: {}
+            variables: {},
+            nested_fields: {},
           },
           mutation: {},
         }

diff --git a/ndc-lambda-sdk/src/schema.ts b/ndc-lambda-sdk/src/schema.ts
@@ -298,7 +298,7 @@ function convertBuiltInScalarTypeIntoSdkSchemaType(typeName: BuiltInScalarTypeNa
       comparison_operators: { "_eq": { type: "equal" } },
     };
     case BuiltInScalarTypeName.BigInt: return {
-      representation: { type: "int64" }, // NDC doesn't have a good representation for this type as at v0.1.2, so this is the best representation in the meantime
+      representation: { type: "biginteger" },
       aggregate_functions: {},
       comparison_operators: { "_eq": { type: "equal" } },
     };

diff --git a/ndc-lambda-sdk/test/schema/ndc-schema.test.ts b/ndc-lambda-sdk/test/schema/ndc-schema.test.ts
@@ -233,7 +233,7 @@ describe("ndc schema", function() {
           }
         },
         "BigInt": {
-          representation: { type: "int64" },
+          representation: { type: "biginteger" },
           aggregate_functions: {},
           comparison_operators: {
             "_eq": { type: "equal" }