Added redirect and user context opt-out for private pages.#120
Open
Added redirect and user context opt-out for private pages.#120
Conversation
Collaborator
edyhtan
commented
Feb 4, 2021
edyhtan
commented
- Added redirect to log in for pages that explicitly require a current user: contest creation, submission, and messenger.
- Automatically reset UserContext if the existing token is long expired.
bonnieli
reviewed
Feb 5, 2021
client/src/pages/SubmitDesign.js
Outdated
|
|
||
| if (user.username === "no-user") { | ||
| return ( | ||
| <Redirect to='/login'/> |
Contributor
There was a problem hiding this comment.
hm with this, if user doesn't load just yet, will this redirect to login? for example if you refresh this submit design page, the user i'm guessing won't load as fast as this page gets rendered
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.