fix bugs (#61)

* code compiles * explanation * explanation * more descriptive name * michael feedback * bugfix
hathora · Jun 11, 2024 · ee207c1 · ee207c1
1 parent 3ffbe0a
commit ee207c1
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 21 deletions.
diff --git a/client/src/components/lobby/PublicLobbyList.tsx b/client/src/components/lobby/PublicLobbyList.tsx
@@ -29,7 +29,7 @@ export function PublicLobbyList(props: PublicLobbyListProps) {
       // Ensure that lobby is ready for connections before adding to visible lobby list
       await isReadyForConnect(appId, lobby.roomId, hathoraSdk);
       setReadyRooms((prev) => {
-        return new Set([...prev, l.roomId]);
+        return new Set([...prev, lobby.roomId]);
       });
     });
   }, [lobbies, appId]);
@@ -148,20 +148,12 @@ function useLobbies(appId: string): LobbyV3[] {
   const [lobbies, setLobbies] = React.useState<LobbyV3[]>([]);
   React.useEffect(() => {
     if (appId) {
-      hathoraSdk.lobbiesV3.listActivePublicLobbies().then((lobbies) => {
-        if (lobbies != null) {
-          setLobbies(lobbies);
-        }
-      });
+      hathoraSdk.lobbiesV3.listActivePublicLobbies().then(setLobbies);
     }
   }, [appId]);
   useInterval(() => {
     if (appId) {
-      hathoraSdk.lobbiesV3.listActivePublicLobbies().then((lobbies) => {
-        if (lobbies != null) {
-          setLobbies(lobbies);
-        }
-      });
+      hathoraSdk.lobbiesV3.listActivePublicLobbies().then(setLobbies);
     }
   }, 2000);
   return lobbies;

diff --git a/client/src/components/website/ExplanationText.tsx b/client/src/components/website/ExplanationText.tsx
@@ -400,20 +400,12 @@ function useLobbies(appId: string): LobbyV3[] {
   const [lobbies, setLobbies] = React.useState<LobbyV3[]>([]);
   React.useEffect(() => {
     if (appId) {
-      hathoraSdk.lobbiesV3.listActivePublicLobbies().then((lobbies) => {
-        if (lobbies != null) {
-          setLobbies(lobbies);
-        }
-      });
+      hathoraSdk.lobbiesV3.listActivePublicLobbies().then(setLobbies);
     }
   }, [appId]);
   useInterval(() => {
     if (appId) {
-      hathoraSdk.lobbiesV3.listActivePublicLobbies().then((lobbies) => {
-        if (lobbies != null) {
-          setLobbies(lobbies);
-        }
-      });
+      hathoraSdk.lobbiesV3.listActivePublicLobbies().then(setLobbies);
     }
   }, 2000);
   return lobbies;