Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating cpu and memory validation #13

Merged
merged 6 commits into from
May 29, 2024
Merged

Updating cpu and memory validation #13

merged 6 commits into from
May 29, 2024

Conversation

msaxon
Copy link
Collaborator

@msaxon msaxon commented May 24, 2024

Changes

  • Updated cpu to have the following validations
    • min of 0.5
    • max of 4
    • max of 1 decimal place
  • Update memory to have the following validations
    • min of 1000
    • max of 8000
  • Combined validation
    • memory must be 2000x cpu
  • Fixed an issue where zipping a directory without a dockerignore or gitignore file through an error

Screenshots

image

@msaxon msaxon changed the title Updating cpu and memory valdiation Updating cpu and memory validation May 24, 2024
gwprice115
gwprice115 approved these changes May 28, 2024
View reviewed changes
internal/commands/deployment.go Outdated Show resolved Hide resolved
@msaxon msaxon merged commit 70f4c5b into main May 29, 2024
13 checks passed
@zlangbert zlangbert deleted the additional-validation branch June 13, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gwprice115 gwprice115 gwprice115 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msaxon @gwprice115