Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support sourcing deployment ENVs from config file #63

Merged
merged 9 commits into from
Dec 17, 2024

Conversation

jranson
Copy link
Contributor

@jranson jranson commented Dec 11, 2024

This contribution provides the ability to include and source ENVs in a config file as follows:

deployment:
  env:
    - ENV1=VALUE1
    - ENV2=VALUE2

It was also determined that addtiional-container-ports was not properly parsing from a config file; this is also fixed.

deployment:
  additional-container-ports:
    - debug:4000/tcp
    - label2:4001/udp

Lastly, it also includes some general cleanup of vars and repetitive raw strings that should be consts.

@jranson jranson marked this pull request as draft December 11, 2024 19:30
@jranson jranson marked this pull request as ready for review December 11, 2024 20:50
@gwprice115 gwprice115 merged commit 7265ebe into hathora:main Dec 17, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants