Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate monitor.py #1245

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Deprecate monitor.py #1245

wants to merge 4 commits into from

Conversation

rly
Copy link
Contributor

@rly rly commented Feb 7, 2025

Motivation

monitor.py is not used and was ported over from the beginning of HDMF. It looks to contain an abstract utility class for monitoring the progress of processing DataChunkIterator objects, and it contains an example of such a class. Neither is used or documented. To improve maintainability of HDMF, I propose we deprecate the module and remove it in HDMF 5.0.

Related: #766

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Does the PR clearly describe the problem and the solution?
  • Have you reviewed our Contributing Guide?
  • Does the PR use "Fix #XXX" notation to tell GitHub to close the relevant issue numbered XXX when the PR is merged?

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.07%. Comparing base (b8a1a26) to head (d79e113).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1245      +/-   ##
==========================================
+ Coverage   90.87%   91.07%   +0.20%     
==========================================
  Files          42       42              
  Lines        9537     9539       +2     
  Branches     1926     1926              
==========================================
+ Hits         8667     8688      +21     
+ Misses        576      557      -19     
  Partials      294      294              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rly rly enabled auto-merge (squash) February 8, 2025 07:06
@rly rly requested a review from mavaylon1 February 8, 2025 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant