flux: add external artifacts #406
Merged
+28
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this. If there's formatting, lint, or type check issues in the github check you can run locally: npm run format
npm run lint-fix
npm run tsc |
viceice
force-pushed
the
feat/externalartifacts
branch
from
3486e85 to
b549fc3
Compare
|
ok, need to clone to wsl as the commands don't work on windows 🙃 |
Signed-off-by: Michael Kriese <[email protected]>
viceice
force-pushed
the
feat/externalartifacts
branch
from
b549fc3 to
f474f6d
Compare
|
works 💪 |
|
Would be nice to have this released soon, so i can continue using |
|
@illume anything missing here? This is really a blocker for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExternalArtifactviews #405have not yet tested