Remove unused field validation scaffolding and TODO comments#25
Merged
Conversation
The valid_search_fields parameter was passed through Endpoint#build_query and QueryBuilder#initialize but never used — validation was commented out and only triggered a noisy warn statement. Removing it entirely: - Drop valid_search_fields param from QueryBuilder#initialize and Endpoint#build_query - Remove private dead methods: validate_arguments!, get_invalid_fields, count_and_skip_set? - Remove warn statement and commented-out validation call - Remove all "# TODO: Upload valid fields" comments from endpoint files - Delete adverse_events_fields.yml (no longer referenced) - Remove YAML require and valid_adverse_events_fields class method from Drugs - Update query_builder_spec to remove valid_search_fields references Coverage is now at 99.79%. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.