[HLS-3076] reapply changes #102
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LironKS
reviewed
Jan 16, 2023
| delegateField.setAccessible(true); | ||
| Object delegate = delegateField.get(mapData.get(attributes.get(carrier))); | ||
| Map<String, String> newAttributes = (Map) delegate; | ||
| newAttributes.put(key, value); |
There was a problem hiding this comment.
If I remember correctly we have exported all this to an external function - it makes me think that we are missing here some more updated commit
…st temporarily (or for good, we'll see)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nozik @LironKS
Ignore the
.github/workflowschanges for now - I just want to be aligned with the tasks we had inmainso far so I re-applied them as well (although I think we should not touch them, just disable them in github, and create our own tasks).What we do need to go over are all the instrumentation changes which I re-applied - basically they should all be "additions" of code, but I think there were a few places where we updated/removed stuff. Have a look.