Update Installation.php

[jm-extend]

retrieve the store from the session for the current order, to address an issue in the admin where the region is passed incorrectly to admin orders

Summary by CodeRabbit

• Bug Fixes
  • Improved reliability of store selection during order creation by ensuring the correct store is retrieved from the session rather than the request data.

[coderabbitai]

Walkthrough

The changes update the Installation class in Block/Adminhtml/Order/Create/Installation.php to retrieve the current store ID from the backend session quote object rather than from the HTTP POST request. This is accomplished by injecting the \Magento\Backend\Model\Session\Quote dependency through the constructor and storing it as a private property. The getCurrentStore() method is modified to return the store ID from the session quote. The constructor is added for dependency injection, and unused imports are removed.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Poem

A hop through code, a change so neat,
Store IDs no longer from POST we greet.
Dependency injected, a session in tow,
The quote now tells us which store to know.
With every hop, the logic’s more clear—
A rabbit’s delight, the right store is near!
🐇✨

Note

🔌 MCP (Model Context Protocol) integration is now available in Early Access!

Pro users can now connect to remote MCP servers under the Integrations page to get reviews and chat conversations that understand additional development context.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cc9dcda and 04330ef.

📒 Files selected for processing (1)

• Block/Adminhtml/Order/Create/Installation.php (1 hunks)

🔇 Additional comments (1)

Block/Adminhtml/Order/Create/Installation.php (1)

18-23: Session quote property + docblock: LGTM

Property encapsulation and @var typing look good and align with the new usage.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch region_fix

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e5fcb18 and cc9dcda.

📒 Files selected for processing (1)

• Block/Adminhtml/Order/Create/Installation.php (1 hunks)

🔇 Additional comments (3)

Block/Adminhtml/Order/Create/Installation.php (3)

18-23: Session Quote dependency introduction — good call

Using the backend session quote as a dependency is the right source of truth for admin order creation and avoids relying on mutable POST data.

---

33-35: Correct source for store context in admin create-order flow

Returning the store ID from the session quote is the right fix and reduces risk of incorrect/forged POST values, addressing the region mismatch in admin orders.

---

33-35: No chaining usages of getCurrentStore() detected

All discovered calls to getCurrentStore() simply treat its return value as an integer store ID—there are no downstream method chains expecting a Store object:

• view/adminhtml/templates/installation.phtml:
  $currentStoreId = $block->getCurrentStore();
  Passed directly to $viewModel->isExtendEnabled($currentStoreId)
• Block/Adminhtml/Order/View/Installation.php also defines getCurrentStore() returning an int and is not chained.

Since no code or template chains methods on getCurrentStore(), it’s safe that this method now returns an ID.