Skip to content

crates/trust: add public set_upstream_state_id function#932

Merged
ClaytonNorthey92 merged 1 commit intomainfrom
clayton/set-upstream-state-id
Mar 24, 2026
Merged

crates/trust: add public set_upstream_state_id function#932
ClaytonNorthey92 merged 1 commit intomainfrom
clayton/set-upstream-state-id

Conversation

@ClaytonNorthey92
Copy link
Copy Markdown
Contributor

@ClaytonNorthey92 ClaytonNorthey92 commented Mar 24, 2026

Summary

  • add public function set_upstream_state_id to trust

fixes #923

Changes
see summary

@github-actions github-actions bot added the changelog: required This pull request must update the CHANGELOG.md file or explicitly be marked with changelog: skip label Mar 24, 2026
@ClaytonNorthey92 ClaytonNorthey92 force-pushed the clayton/set-upstream-state-id branch 2 times, most recently from 83415f7 to dada16e Compare March 24, 2026 18:55
@ClaytonNorthey92 ClaytonNorthey92 added changelog: done This pull request includes an appropriate update to CHANGELOG.md. and removed changelog: required This pull request must update the CHANGELOG.md file or explicitly be marked with changelog: skip labels Mar 24, 2026
@github-actions github-actions bot added changelog: required This pull request must update the CHANGELOG.md file or explicitly be marked with changelog: skip area: docs This is a change to documentation changelog: done This pull request includes an appropriate update to CHANGELOG.md. and removed changelog: done This pull request includes an appropriate update to CHANGELOG.md. changelog: required This pull request must update the CHANGELOG.md file or explicitly be marked with changelog: skip labels Mar 24, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@ClaytonNorthey92 ClaytonNorthey92 force-pushed the clayton/set-upstream-state-id branch 3 times, most recently from 23d6b6e to 1375470 Compare March 24, 2026 19:12
@ClaytonNorthey92 ClaytonNorthey92 marked this pull request as ready for review March 24, 2026 19:24
@ClaytonNorthey92 ClaytonNorthey92 requested a review from a team as a code owner March 24, 2026 19:24
joshuasing
joshuasing reviewed Mar 24, 2026
View reviewed changes
@joshuasing joshuasing added the type: feature This adds new functionality label Mar 24, 2026
@joshuasing
Copy link
Copy Markdown
Contributor

joshuasing commented Mar 24, 2026 •
edited
Loading

For consistency, PR title (commit message) could be (per https://github.com/hemilabs/heminetwork/blob/main/CONTRIBUTING.md#commit-messages, https://go.dev/wiki/CommitMessage):

crates/trust: add public set_upstream_state_id function

@ClaytonNorthey92 ClaytonNorthey92 force-pushed the clayton/set-upstream-state-id branch 2 times, most recently from 66173c8 to dcc7efa Compare March 24, 2026 19:33
@github-actions github-actions bot added changelog: required This pull request must update the CHANGELOG.md file or explicitly be marked with changelog: skip and removed changelog: done This pull request includes an appropriate update to CHANGELOG.md. labels Mar 24, 2026
@joshuasing joshuasing added changelog: skip This pull request does not require a changelog entry (e.g. tests, docs, CI, minor refactors). and removed changelog: required This pull request must update the CHANGELOG.md file or explicitly be marked with changelog: skip labels Mar 24, 2026
joshuasing
joshuasing approved these changes Mar 24, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@joshuasing joshuasing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! -- See: #932 (comment)

@ClaytonNorthey92
crates/trust: add public set_upstream_state_id function
763e860 
* add public function set_upstream_state_id to trust

fixes #923
@ClaytonNorthey92 ClaytonNorthey92 force-pushed the clayton/set-upstream-state-id branch from dcc7efa to 763e860 Compare March 24, 2026 19:37
@joshuasing joshuasing changed the title feat: add public function set_upstream_state_id to trust crates/trust: add public set_upstream_state_id function Mar 24, 2026
jcvernaleo
jcvernaleo approved these changes Mar 24, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@jcvernaleo jcvernaleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@ClaytonNorthey92 ClaytonNorthey92 merged commit 3da98f7 into main Mar 24, 2026
15 checks passed
@ClaytonNorthey92 ClaytonNorthey92 deleted the clayton/set-upstream-state-id branch March 24, 2026 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcvernaleo jcvernaleo jcvernaleo approved these changes

@joshuasing joshuasing joshuasing approved these changes

@max-sanchez max-sanchez Awaiting requested review from max-sanchez

@marcopeereboom marcopeereboom Awaiting requested review from marcopeereboom

@AL-CT AL-CT Awaiting requested review from AL-CT

Assignees

No one assigned

Labels

area: docs This is a change to documentation changelog: skip This pull request does not require a changelog entry (e.g. tests, docs, CI, minor refactors). type: feature This adds new functionality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

trust: add SetUpstreamStateID

3 participants

@ClaytonNorthey92 @joshuasing @jcvernaleo