Replace useAllowance with lib by arielmergen · Pull Request #1843 · hemilabs/ui-monorepo

arielmergen · 2026-03-23T17:31:31Z

Description

This PR focuses on useAllowance.
useNeedsApproval now wraps the library implementation to avoid Knip unused hook errors after removing the local hook.
The signature change will be handled in a separate PR.

Screenshots

Related issue(s)

Closes #
Fixes #
Related to #1807

Checklist

Manual testing passed.
Automated tests added, or N/A.
Documentation updated, or N/A.
Environment variables set in CI, or N/A.

Copilot

Pull request overview

This PR migrates the portal’s useAllowance hook implementation to delegate to the shared @hemilabs/react-hooks/useAllowance hook, while keeping the existing wrapper signature and still exposing a queryKey for cache invalidation.

Changes:

Replaced wagmi useReadContract usage with useAllowance from @hemilabs/react-hooks.
Preserved the existing enabled guard logic for valid ERC-20 (non-native) addresses and defined owner/spender.
Re-exposed queryKey via the shared lib’s allowanceQueryKey.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated no new comments.

Replace useAllowance with lib

aed0ca2

arielmergen self-assigned this Mar 23, 2026

Copilot AI review requested due to automatic review settings March 23, 2026 17:31

arielmergen requested review from gabmontes and gndelia as code owners March 23, 2026 17:31

Copilot started reviewing on behalf of arielmergen March 23, 2026 17:32 View session

Copilot AI reviewed Mar 23, 2026

View reviewed changes

Comment thread portal/hooks/useAllowance.ts Outdated

Comment thread portal/hooks/useAllowance.ts Outdated

Comment thread portal/hooks/useAllowance.ts Outdated

Add cleanliness and bundle hygiene

50daac2

arielmergen requested a review from Copilot March 23, 2026 17:50

Copilot started reviewing on behalf of arielmergen March 23, 2026 17:51 View session

Copilot AI reviewed Mar 23, 2026

View reviewed changes

Comment thread portal/hooks/useAllowance.ts Outdated

Comment thread portal/hooks/useAllowance.ts Outdated

Add sugestions

d926eac

arielmergen requested a review from Copilot March 23, 2026 18:07

Copilot started reviewing on behalf of arielmergen March 23, 2026 18:08 View session

Copilot AI reviewed Mar 23, 2026

View reviewed changes

Comment thread portal/hooks/useAllowance.ts Outdated

arielmergen requested a review from Copilot March 23, 2026 18:25

Copilot started reviewing on behalf of arielmergen March 23, 2026 18:25 View session

Copilot AI reviewed Mar 23, 2026

View reviewed changes

arielmergen requested a review from ArturDolzan March 23, 2026 19:56

gabmontes reviewed Mar 23, 2026

View reviewed changes

Comment thread portal/hooks/useAllowance.ts Outdated

arielmergen mentioned this pull request Mar 23, 2026

Migrates to call useAllowance lib #1844

Closed

4 tasks

arielmergen requested a review from gabmontes March 23, 2026 21:31

arielmergen added 4 commits March 25, 2026 12:04

Migrates to call useAllowance lib

810d8dc

Applies fix stakeOperation

6eb83f6

Replace useAllowance with allowanceQueryKey

2bd9973

Unify useAllowance one commit

4a972af

arielmergen requested a review from Copilot March 25, 2026 16:07

Copilot started reviewing on behalf of arielmergen March 25, 2026 16:08 View session

Copilot AI reviewed Mar 25, 2026

View reviewed changes

Comment thread portal/hooks/useNeedsApproval.ts

Comment thread portal/app/[locale]/stake/_components/manageStake/stakeOperation.tsx Outdated

Applies suggestion

099706d

arielmergen requested a review from Copilot March 25, 2026 16:37

Copilot started reviewing on behalf of arielmergen March 25, 2026 16:37 View session

Copilot AI reviewed Mar 25, 2026

View reviewed changes

Comment thread portal/app/[locale]/stake/_components/manageStake/stakeOperation.tsx Outdated

Comment thread portal/hooks/useNeedsApproval.ts Outdated

Add suggestions

301e504

arielmergen requested a review from Copilot March 25, 2026 17:43

Copilot started reviewing on behalf of arielmergen March 25, 2026 17:43 View session

Copilot AI reviewed Mar 25, 2026

View reviewed changes

Add util to normalize address

4786b7d

arielmergen requested a review from Copilot March 26, 2026 14:14

Copilot started reviewing on behalf of arielmergen March 26, 2026 14:15 View session

Copilot AI reviewed Mar 26, 2026

View reviewed changes

Comment thread portal/app/[locale]/stake/_components/manageStake/stakeOperation.tsx Outdated

Comment thread portal/utils/allowanceQueryKey.ts

gndelia reviewed Mar 26, 2026

View reviewed changes

Comment thread portal/hooks/useNeedsApproval.ts Outdated

gndelia reviewed Mar 26, 2026

View reviewed changes

Comment thread portal/app/[locale]/stake/_components/manageStake/stakeOperation.tsx Outdated

gndelia reviewed Mar 26, 2026

View reviewed changes

Comment thread portal/app/[locale]/stake/_components/manageStake/stakeOperation.tsx Outdated

Applies suggestions

721b598

arielmergen requested a review from Copilot March 26, 2026 16:04

Copilot started reviewing on behalf of arielmergen March 26, 2026 16:04 View session

Copilot AI reviewed Mar 26, 2026

View reviewed changes

arielmergen requested a review from gndelia March 26, 2026 16:10

gndelia approved these changes Mar 26, 2026

View reviewed changes

gabmontes reviewed Mar 26, 2026

View reviewed changes

Comment thread portal/utils/allowanceQueryKey.ts

arielmergen requested a review from gabmontes March 27, 2026 02:22

gabmontes approved these changes Mar 27, 2026

View reviewed changes

arielmergen merged commit 63756d8 into main Mar 27, 2026
11 checks passed

arielmergen deleted the replace-hooks-allowance branch March 27, 2026 14:44

Conversation

arielmergen commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Screenshots

Related issue(s)

Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

arielmergen commented Mar 23, 2026 •

edited

Loading