This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
Implement scaling modes and scaling step mode #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As follow up to my other PR #3 I've made improvments to the system.... that kinda changed a lot, so i will understand if you will not be interested in merging this.
As this PR adds full support for multiple modes of scaling, and decorators/wrappers (not configurable now, could be done, but i dont see benefits for now), there is old ratio one, and more advanced one with manually defined steps using ranges.
Additionaly I've added a wrapper that avoids sudden changes in distances, as during testing i once change render distance from 32 to 10 and half of my players timeouted... So now sudden changes are limited to changing only 256 chunks at once (could be extracted to config) but will continue with each next check of mspt.
Might require a bit more testing, didn't use this yet with more people online.