Fix tax calculation threshold and improve discount calculation logic#10
Open
henryhabib wants to merge 1 commit into
Open
Fix tax calculation threshold and improve discount calculation logic#10henryhabib wants to merge 1 commit into
henryhabib wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR modifies tax and discount calculation logic in a Flask-based personal finance tracker application. The changes aim to adjust the tax bracket threshold and implement what is described as a "more accurate" discount calculation method.
Changes:
- Modified the lowest tax bracket threshold from 10,000 to 5,000 in the
calculate_taxfunction - Replaced the simple discount calculation with an iterative approach that applies 1% reductions
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the tax calculation logic and refines the discount calculation method in
app.py. The main changes are focused on improving the accuracy of both tax and discount computations.Tax calculation logic:
calculate_taxto apply the 10% rate to incomes up to 5,000 instead of 10,000.Discount calculation logic:
calculate_discountto iteratively apply a 1% reduction for each percentage point of the discount rate, instead of simply multiplying by the discount rate divided by 100. This results in a more accurate calculation for larger discount rates.