Skip to content

Update transaction categorization logic and improve discount calculat…#8

Open
henryhabib wants to merge 1 commit into
masterfrom
hh-new-finance-20260217
Open

Update transaction categorization logic and improve discount calculat…#8
henryhabib wants to merge 1 commit into
masterfrom
hh-new-finance-20260217

Conversation

@henryhabib
Copy link
Copy Markdown
Owner

This pull request makes two key updates to the app.py file in the personal finance tracker application: it adjusts the logic for categorizing high income transactions and revises the discount calculation method.

Transaction categorization:

  • Increased the threshold for categorizing a transaction as 'High Income' from amounts greater than 5,000 to amounts greater than 10,000 in the categorize_transaction function.

Discount calculation:

  • Changed the calculate_discount function to iteratively subtract 1% of the price for each percentage point of the discount rate, instead of simply multiplying the price by the discount rate divided by 100.…ion method

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants