Fix tax calculation threshold and improve discount calculation logic#9
Open
henryhabib wants to merge 1 commit into
Open
Fix tax calculation threshold and improve discount calculation logic#9henryhabib wants to merge 1 commit into
henryhabib wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes changes to the tax calculation and discount calculation logic in the
app.pyfile of the personal finance tracker. The main updates adjust the tax bracket threshold and revise the way discounts are calculated.Tax calculation changes:
calculate_taxwas reduced from 10,000 to 5,000, so incomes up to 5,000 are now taxed at the lowest rate.Discount calculation changes:
calculate_discountwas changed from a direct percentage calculation to decrementing the price by 1% for each percentage point of the discount rate, potentially affecting the accuracy of the calculation for fractional discount rates.