partitions: allow overriding the flake-compat src #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful when flake-compat is already available, e.g. as a flake input. By allowing consumers to specify the flake-compat to use, we can avoid fetching multiple redundant copies.
|
Maybe this is conceptually flawed too, since most of the time a flake shouldn't have flake-compat in its unconditional root flake inputs. So the existing behavior of fetching flake-compat only when evaluating a partition is probably best. This new option may encourage consumers to specify a superfluous flake-compat input in their flakes 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful when flake-compat is already available, e.g. as a flake input. By allowing consumers to specify the flake-compat to use, they can avoid fetching multiple redundant copies.
It feels like this could be managed with flake inputs and the
followssystem, however we only depend on flake-compat when a) the partitions module is used, b) a partition has a path-type flake, and c) that partition is actually evaluated. Using a follow-able input would make flake-compat an unconditional dependency. Therefore, I've introduced an internal option that can be used instead (flakeCompatSrc).Maybe the option doesn't need to be internal. I've added the appropriate docs in case it is marked as public (or someone reads the source code). However, the use of
flake-compatvsbuiltins.getFlakefeels like an internal implementation detail, so I was hesitant to make it a public/visible option.