Skip to content

Fix DropIndexes step to select all indices & constraints of the space-table for deletion #1300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fix DropIndexes step to select all indices & constraints of the space-table for deletion #1300

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 24 additions & 8 deletions xyz-jobs/xyz-job-steps/src/main/java/com/here/xyz/jobs/steps/impl/DropIndexes.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,31 +77,47 @@ private int calculateNeededAcus() {

@Override
public void execute() throws SQLException, TooManyResourcesClaimed, WebClientException {
logger.info("Loading space config for space " + getSpaceId());
logger.info("[{}] Loading space config for space {} ...", getGlobalStepId(), getSpaceId());
Space space = loadSpace(getSpaceId());
logger.info("Getting storage database for space " + getSpaceId());

logger.info("[{}] Getting storage database for space {} ...", getGlobalStepId(), getSpaceId());
Database db = loadDatabase(space.getStorage().getId(), WRITER);
logger.info("Gathering indices of space " + getSpaceId());
List<String> indexes = runReadQuerySync(buildLoadSpaceTableIndicesQuery(getSchema(db), getRootTableName(space)), db, calculateNeededAcus(),

logger.info("[{}] Gathering indices of space {} ...", getGlobalStepId(), getSpaceId());
String schema = getSchema(db);
String rootTable = getRootTableName(space);
List<String> indexNames = runReadQuerySync(buildLoadSpaceTableIndicesQuery(schema, rootTable), db, calculateNeededAcus(),
rs -> {
List<String> result = new ArrayList<>();
while(rs.next())
result.add(rs.getString(1));
return result;
});

if (indexes.isEmpty()) {
if (indexNames.isEmpty()) {
reportAsyncSuccess();
logger.info("No indices to found. None will be dropped for space " + getSpaceId());
logger.info("[{}] No indices to found. None were dropped for space {}.", getGlobalStepId(), getSpaceId());
}
else {
logger.info("Dropping the following indices for space " + getSpaceId() + ": " + indexes);
List<SQLQuery> dropQueries = buildSpaceTableDropIndexQueries(getSchema(db), indexes);
List dropQueries = new ArrayList();
//Ensure to drop constraints
dropQueries.add(buildDropConstraintQuery(schema, rootTable, rootTable + "_primKey"));
dropQueries.add(buildDropConstraintQuery(schema, rootTable, rootTable + "_unique"));

logger.info("[{}] Dropping the following indices for space {}: {} ...", getGlobalStepId(), getSpaceId(), indexNames);
dropQueries.addAll(buildSpaceTableDropIndexQueries(schema, indexNames));
SQLQuery dropIndexesQuery = SQLQuery.join(dropQueries, ";");
runWriteQueryAsync(dropIndexesQuery, db, calculateNeededAcus());
}
}

private static SQLQuery buildDropConstraintQuery(String schema, String rootTable, String constraintName) {
return new SQLQuery("ALTER TABLE ${schema}.${rootTable} DROP CONSTRAINT ${constraintName}")
.withVariable("schema", schema)
.withVariable("rootTable", rootTable)
.withVariable("constraintName", constraintName);
}

@Override
public void resume() throws Exception {
execute();
Expand Down