Skip to content

DS-1184: Fix rare concurrency issue during EMR step updates #1597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

DS-1184: Fix rare concurrency issue during EMR step updates #1597

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion xyz-jobs/xyz-job-service/src/main/java/com/here/xyz/jobs/Job.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,6 +379,7 @@ private Future<Void> updateStep(Step step, State previousStepState, boolean canc
getStatus().setEstimatedProgress((float) completedWorkUnits / (float) overallWorkUnits);

//Update the job's state if applicable
State previousJobState = getStatus().getState();
if (previousStepState != FAILED && step.getStatus().getState() == FAILED) {
getStatus()
.withState(FAILED)
Expand All @@ -388,7 +389,7 @@ private Future<Void> updateStep(Step step, State previousStepState, boolean canc
}

return storeUpdatedStep(step)
.compose(v -> storeStatus(null))
.compose(v -> storeStatus(previousJobState))
.compose(v -> getStatus().getState() == FAILED && cancelOnFailure ?
JobExecutor.getInstance().cancel(getExecutionId(), "Cancelled due to failed step \"" + step.getId() + "\"")
.recover(t -> {
Expand Down