enhancement: Moved all javascript package managers under /javascript for consolidation

[mohamedbouchtout]

Summery

Moved the package managers npm, yarn, yarn_classic and metayarn.py file under hermeto/core/package_managers/javascript as mentioned in this issue. Then also updated all imports path for each of the relocated files throughout the project. Also moved their unit tests under the /javascript folder to match.

Details

1. Moved npm package manager:
   • hermeto/core/package_managers/npm -> hermeto/core/package_managers/javascript/npm
   • hermeto/test/unit/package_managers/npm -> hermeto/test/unit/package_managers/javascript/npm
2. Moved yarn package manager:
   • hermeto/core/package_managers/yarn -> hermeto/core/package_managers/javascript/yarn
   • hermeto/test/unit/package_managers/yarn -> hermeto/test/unit/package_managers/javascript/yarn
3. Moved yarn_classic package manager:
   • hermeto/core/package_managers/yarn_classic -> hermeto/core/package_managers/javascript/yarn_classic
   • hermeto/test/unit/package_managers/yarn_classic -> hermeto/test/unit/package_managers/javascript/yarn_classic
4. Moved metayarn.py file:
   • hermeto/core/package_managers/metayarn.py -> hermeto/core/package_managers/javascript/metayarn.py
   • hermeto/test/unit/package_managers/metayarn.py -> hermeto/test/unit/package_managers/javascript/metayarn.py
5. Added the /javascript folder in the import paths:
   • In the npm, pnpm, yarn, and yarn_classic package manager
   • In the metayarn.py file
   • In the resolver.py file
   • In all the package manager tests

[gemini-code-assist]

Code Review

This pull request reorganizes the codebase by consolidating JavaScript-related package managers (npm, yarn, yarn_classic, and metayarn) under a new hermeto/core/package_managers/javascript/ directory, updating all relevant imports and mock patches. Feedback on this PR points out that the corresponding unit test files and directories have not been relocated to match this new structure. Moving these tests under tests/unit/package_managers/javascript/ is recommended to maintain a consistent code structure across the codebase.

[gemini-code-assist]

The package managers npm, yarn, yarn_classic, and metayarn have been consolidated under hermeto/core/package_managers/javascript/. However, their corresponding unit tests (e.g., tests/unit/package_managers/test_metayarn.py, tests/unit/package_managers/npm/, tests/unit/package_managers/yarn/, and tests/unit/package_managers/yarn_classic/) have not been moved under tests/unit/package_managers/javascript/. To maintain a consistent code structure across the whole codebase, please relocate these test files/directories to match the new package manager structure.

References

1. Maintain a consistent code structure across the whole code base ^(link)

[eskultety]

@mohamedbouchtout please make sure every single commit passes both linters and unit tests, i.e. nox.

[slimreaper35]

I believe the first six commits should be combined with the other six.

[mohamedbouchtout]

@slimreaper35 So maybe squash like commit 1, 5, and 9 which would include "Moved npm package manager and it's unit tests under the /javascript folder; updates it's import paths to new location". And do the same with the rest which will bring it down to 4 commit?

[slimreaper35]

@slimreaper35 So maybe squash like commit 1, 5, and 9 which would include "Moved npm package manager and it's unit tests under the /javascript folder; updates it's import paths to new location". And do the same with the rest which will bring it down to 4 commit?

For example, the first commit moves the whole package_managers/npm directory to package_managers/javascript/npm. But the tests still expect the previous package_managers/npm so they fail. It's related to the #1591 (comment).

[eskultety]

@slimreaper35 So maybe squash like commit 1, 5, and 9 which would include "Moved npm package manager and it's unit tests under the /javascript folder; updates it's import paths to new location". And do the same with the rest which will bring it down to 4 commit?

For example, the first commit moves the whole package_managers/npm directory to package_managers/javascript/npm. But the tests still expect the previous package_managers/npm so they fail. It's related to the #1591 (comment).

Yes, the backend changes should be paired with the corresponding unit test changes in a single commit and we should be good (always verify with nox).

[mohamedbouchtout]

@slimreaper35 So maybe squash like commit 1, 5, and 9 which would include "Moved npm package manager and it's unit tests under the /javascript folder; updates it's import paths to new location". And do the same with the rest which will bring it down to 4 commit?

For example, the first commit moves the whole package_managers/npm directory to package_managers/javascript/npm. But the tests still expect the previous package_managers/npm so they fail. It's related to the #1591 (comment).

Yes, the backend changes should be paired with the corresponding unit test changes in a single commit and we should be good (always verify with nox).

I agree, so we don't have redundant commits. I've squashed the commits together and updated their message.

[eskultety]

@mohamedbouchtout there are some merge conflicts here (not a coincidence since there's active work on the pnpm backend going on) that need resolving.