Replace deprecated aiohttp.BasicAuth#1610
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the file download mechanism to use string-based Authorization headers instead of aiohttp.BasicAuth objects, utilizing aiohttp.encode_basic_auth where appropriate. The review feedback suggests simplifying the dynamic keyword arguments construction in _async_download_binary_file by passing the headers parameter directly to session.get with a conditional expression, which improves readability and maintains a cleaner code structure.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Let's wait for #1585, which has higher priority, because it will introduce merge conflicts. |
The class has been deprecated in favour of encode_basic_auth() function. It will be removed in aiohttp version 4. In fact, it does not exist on the master branch in the aiohttp GitHub repo. However, the releases come from other branches. -- https://github.com/aio-libs/aiohttp/pull/12499/changes aio-libs/aiohttp@247b323 Signed-off-by: Michal Šoltis <msoltis@redhat.com>
3 participants
No description provided.