Skip to content
This repository has been archived by the owner on Mar 16, 2024. It is now read-only.

Properly close response body before retrying #68

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions registry/tokentransport.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ package registry
import (
"encoding/json"
"fmt"
"io"
"io/ioutil"
"net/http"
"net/url"
)
Expand All @@ -13,12 +15,18 @@ type TokenTransport struct {
Password string
}

func discardResponse(resp *http.Response) {
_, _ = io.Copy(ioutil.Discard, resp.Body)
resp.Body.Close()
}

func (t *TokenTransport) RoundTrip(req *http.Request) (*http.Response, error) {
resp, err := t.Transport.RoundTrip(req)
if err != nil {
return resp, err
}
if authService := isTokenDemand(resp); authService != nil {
discardResponse(resp)
resp, err = t.authAndRetry(authService, req)
}
return resp, err
Expand Down