This repository was archived by the owner on Oct 15, 2024. It is now read-only.
Detect GNUmakefile too #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. The buildpack doesn't check for the existence of a GNUmakefile, which is a valid name for a makefile under GNU Make, but specific to GNU Make. A reason to use this file is, for example, if a project uses GNU Make extensions and a wishes to provide only GNUmakefile and leave the chance to create a more portable Makefile later.
According to the manual, GNU Make looks for Make files in the following order: GNUmakefile, makefile, Makefile.
I'm not sure if this is the correct fix and it is untested. What do you think? Comments and rejections welcome. Thanks.