Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use bnum in favour of num-bigint #12

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Use bnum in favour of num-bigint #12

merged 1 commit into from
Apr 8, 2024

Conversation

hesampakdaman
Copy link
Owner

@hesampakdaman hesampakdaman commented Apr 8, 2024 •
edited
Loading

Changes

We noticed that using num-bigint increased factorization with Pollard's Rho considerably. After trying out several more crates we found that bnum was a nice comprise of features and performance. The decision is to limit numbers to 512bits.

  • Removes crate num-bigint
  • Adds bnum crate and uses U512

@hesampakdaman hesampakdaman merged commit b4ec5e9 into main Apr 8, 2024
1 check passed
@hesampakdaman hesampakdaman deleted the use-bnum branch April 8, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hesampakdaman