Repository navigation
Refactor and add Live Monitor - #9
Merged
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4fc701420d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Add deterministic App Store screenshot support and related project updates. - Introduce InspectionAppStoreScreenshotView and InspectionScreenshotFixtures to render seeded screenshot scenarios and monitor data for screenshots. - Update InspectAppRootView to present the screenshot view when INSPECT_SCREENSHOT_SCENARIO is set; make InspectionMonitorView injectable with a monitor store for test/screenshot purposes. - Replace old screenshot scenario cases with new scenarios (inspect-tab, monitor-tab, host-detail, certificate-chain) and adjust scenario logic accordingly. - Add GPLv3 LICENSE, set ITSAppUsesNonExemptEncryption=false in multiple Info.plist files, bump MARKETING_VERSION/CURRENT_PROJECT_VERSION to 2.3/73, add release notes, update README/plan, and adjust the screenshot capture script to new scenario names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8