codegen: keep generated fixtures on LF - #340
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On Windows with core.autocrlf=true, the codegen golden tests compare LF generated output with CRLF checked-in fixtures, and the surface allowlist regex sees the carriage return. Add a repository-level text policy that keeps text files on LF so a clean Windows checkout passes the same tests without changing generated source or runtime behavior. Fixes #339.
Testing
In a fresh clone of this branch with core.autocrlf=true, go test ./codegen -run TestGoldenFiles|TestSurfaceAllowlistCoversEveryTemplateField|TestSurfaceAllowlistMatchesRealGeneratedLines -count=1 passes all 6 tests. The full go test ./... run reports 1,159 passed, 2 failed, and 6 skipped; the two failures invoke WSL bash, which is unavailable in this native Windows environment.