Add module info for main artifacts#192
Draft
marko-bekhta wants to merge 2 commits intohibernate:mainfrom
Draft
Conversation
since it requires the java.desktop module, and actually might not be available.
Co-authored-by: Andrea Boriero <[email protected]>
yrodiere
reviewed
Jan 27, 2026
Member
yrodiere
left a comment
yrodiere
left a comment
There was a problem hiding this comment.
Nice! Not much to say... I guess you'll be looking into automated testing in the modulepath next?
Comment on lines
+9
to
+10
| // exports org.hibernate.models.bytebuddy.internal; | ||
| // exports org.hibernate.models.bytebuddy.internal.values; |
Member
There was a problem hiding this comment.
Why the commented lines? Should this be an exports ... to org.hibernate.orm.core?
Member
Author
There was a problem hiding this comment.
we used jdeps to generate the initial files. We commented out all internal packages, with the hope that we can just drop them, but as we were testing ... we started to add those exports to orm or other models modules,
so in short ... the idea was to keep all the packages for now while we test how things go with other projects 🫣 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening this one as a draft...
We've tested this with @dreab8 on Hibernate Search and it seems to work...
There are a few things we probably want to address before moving forward with this:
cc: @yrodiere