HHH-18198 - Remove @org.hibernate.annotations.Target #10040
Conversation
jrenaat
force-pushed
the
HHH-18198_removeTarget
branch
from
c651880 to
22ce27a
Compare
| public @interface TargetEmbeddable { | ||
| /** | ||
| * The target type for a {@link jakarta.persistence.Embedded} entity property | ||
| */ | ||
| Class<?> value(); | ||
| } |
There was a problem hiding this comment.
I thought we had decided we didn't need this and we were going to just discover the implementing embeddable class automatically like what we do with polymorphic embeddables?
There was a problem hiding this comment.
We decided to do both. If there is just one, we should just pick it.
There was a problem hiding this comment.
We decided to do both. If there is just one, we should just pick it.
Tbh, I cannot find where or how to do this
There was a problem hiding this comment.
Yeah, navigating around all this *Binder stuff is a nightmare. I feel ya.
I'd try this (I believe it will work, but not certain):
- In PropertyInferredData, just return the declared type (this is the part specifically I am not certain will work).
- Move this handling for "concrete type" into EmbeddableBinder.
- If there is an explicit TargetEmbeddable annotation, use that
- If the declared type is a class, use that
- If the declared type is an interface and there is a single concrete implementation of the interface and use that
- throw an exception
There was a problem hiding this comment.
Yeah, navigating around all this *Binder stuff is a nightmare. I feel ya.
After a number of hours of debugging this stuff, I was ready to tender my resignation ... 😫
There was a problem hiding this comment.
Definitely understand :D
Its one of the main things I want to address with the phased approach I want to do in 8 (needs hbm.xml support dropped first).
There was a problem hiding this comment.
discover the implementing embeddable class automatically
So it turns out this won't work without a change to hibernate-models. Currently it tracks {class -> subclasses}, but that does not account for interfaces. We'd need to add that capability for this to work fully.
There was a problem hiding this comment.
There was a problem hiding this comment.
So let's break this into phases...
- 7.0 -
@TargetEmbeddable - 7.1 - implicit determination (hibernate-models change)
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| private Class<?> value; | ||
|
|
||
| /** | ||
| * Used in creating dynamic annotation instances (e.g. from XML) | ||
| */ | ||
| public TargetLegacyAnnotation(ModelsContext modelContext) { | ||
| public TargetEmbeddableAnnotation(ModelsContext modelContext) { |
Check notice
Code scanning / CodeQL
Useless parameter Note
| } | ||
|
|
||
| /** | ||
| * Used in creating annotation instances from JDK variant | ||
| */ | ||
| public TargetLegacyAnnotation(Target annotation, ModelsContext modelContext) { | ||
| public TargetEmbeddableAnnotation(TargetEmbeddable annotation, ModelsContext modelContext) { |
Check notice
Code scanning / CodeQL
Useless parameter Note
| this.value = annotation.value(); | ||
| } | ||
|
|
||
| /** | ||
| * Used in creating annotation instances from Jandex variant | ||
| */ | ||
| public TargetLegacyAnnotation(Map<String, Object> attributeValues, ModelsContext modelContext) { | ||
| public TargetEmbeddableAnnotation(Map<String, Object> attributeValues, ModelsContext modelContext) { |
Check notice
Code scanning / CodeQL
Useless parameter Note
jrenaat
force-pushed
the
HHH-18198_removeTarget
branch
2 times, most recently
from
aff7bd4 to
1fa01d0
Compare
documentation/src/main/asciidoc/userguide/chapters/domain/embeddables.adoc
Outdated
Show resolved
Hide resolved
documentation/src/main/asciidoc/userguide/chapters/domain/embeddables.adoc
Outdated
Show resolved
Hide resolved
jrenaat
force-pushed
the
HHH-18198_removeTarget
branch
from
1fa01d0 to
ab3b6e1
Compare
hibernate-core/src/main/java/org/hibernate/boot/model/internal/PropertyInferredData.java
Outdated
Show resolved
Hide resolved
documentation/src/main/asciidoc/userguide/chapters/domain/embeddables.adoc
Show resolved
Hide resolved
Removed org.hibernate.annotations.Target Created new org.hibernate.annotations.TargetEmbeddable Signed-off-by: Jan Schatteman <[email protected]>
jrenaat
force-pushed
the
HHH-18198_removeTarget
branch
from
ab3b6e1 to
f09f0ed
Compare
Removed org.hibernate.annotations.Target
Created new org.hibernate.annotations.TargetEmbeddable
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-18198