-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
HHH-18311 Allow constructing SqmMultiTableInsertStrategy/SqmMultiTableMutationStrategy with EntityDomainType and MappingModelCreationProcess #10609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request! This pull request appears to follow the contribution rules. › This message was automatically generated. |
4d3a0be
to
faad336
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this!
I couldn't look at the full implementation, but since it'll apparently well tested, I'm not too concerned. I just have a doubt about the precedence of get*Strategy
vs. resolve*Strategy
... See comment below.
hibernate-testing/src/main/java/org/hibernate/testing/orm/junit/DialectFeatureChecks.java
Outdated
Show resolved
Hide resolved
hibernate-testing/src/main/java/org/hibernate/testing/orm/junit/DialectFeatureChecks.java
Outdated
Show resolved
Hide resolved
...org/hibernate/query/sqm/mutation/internal/SqmMultiTableMutationStrategyProviderStandard.java
Outdated
Show resolved
Hide resolved
f0818fd
to
af9453e
Compare
} | ||
final List<CteColumn> columns = new ArrayList<>( persistentClass.getIdentifier().getColumnSpan() ); | ||
final Metadata metadata = persistentClass.getIdentifier().getBuildingContext().getMetadataCollector(); |
Check notice
Code scanning / CodeQL
Unread local variable Note
…eMutationStrategy with EntityDomainType and MappingModelCreationProcess
…ow configuring other mutation/insert strategies
…ow configuring other mutation/insert strategies
[Please describe here what your change is about]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-19649
https://hibernate.atlassian.net/browse/HHH-18311
https://hibernate.atlassian.net/browse/HHH-19521