Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Envers] HHH-14055 Add UUID support for fields annotated with @RevisionNumber #3425

Open
wants to merge 1 commit into
base: 5.6
Choose a base branch
from

Conversation

bbanchev
Copy link

@bbanchev bbanchev commented Jun 2, 2020

Add fallback check if the field type is of type java.util.UUID
Update corresponding MappingException message

Add fallback check if the field type is of type java.util.UUID
Update corresponding MappingException message
@sebersole sebersole requested a review from Naros June 2, 2020 13:08
@sebersole
Copy link
Member

@RevisionNumber explicitly says that "values of this property should form a strictly-increasing sequence of numbers". A UUID obviously does not fit that description.

@Naros you are much better versed in envers than I... what do you think?

@bbanchev
Copy link
Author

bbanchev commented Jun 2, 2020

@RevisionNumber explicitly says that "values of this property should form a strictly-increasing sequence of numbers". A UUID obviously does not fit that description.

@Naros you are much better versed in envers than I... what do you think?

Actually this is one of the main reasons to ask for this feature - need unpredictable id sequence for revisions. On the other hand fits better in distributed environment.

@sebersole
Copy link
Member

sebersole commented Jun 2, 2020 via email

Base automatically changed from master to main March 19, 2021 16:00
@hibernate-github-bot
Copy link

hibernate-github-bot bot commented Mar 19, 2021

Thanks for your pull request!

This pull request does not follow the contribution rules. Could you have a look?

❌ All commit messages should start with a JIRA issue key matching pattern HHH-\d+
    ↳ Offending commits: [eb7892c]

› This message was automatically generated.

@gavinking gavinking changed the title HHH-14055 - Add UUID support for fields annotated with @RevisionNumber [Envers] HHH-14055 Add UUID support for fields annotated with @RevisionNumber Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants